Abstract: To provide a basis for high quality tobacco production in China, we review the effects of genotype on tobacco quality, the regulation of different genes on tobacco aroma substances, and the effects of light, temperature, moisture, soil, fertilizer and cultivation methods on tobacco quality. The results showed that the quality traits of tobacco were affected by many factors, such as genetic factors, ecological factors and cultivation methods, which had different effects. It could not fundamentally solve the problem of poor quality of tobacco in China by simply improving an individual factor. Therefore, according to the effect of different impact factors, we should strengthen the efficient use of high-aroma breeding resources, breed high-quality tobacco varieties, enhance the application of modern breeding biotechnology, establish and improve the supporting system of high-quality tobacco quality production.